From e5dcc062de1e19cf6d41d2b936ef7e58f1363148 Mon Sep 17 00:00:00 2001 From: hygienic-books Date: Sat, 24 Jun 2023 23:56:43 +0200 Subject: [PATCH] docs(docker-compose): More _FIXME_ markers --- docker-compose/examples/grafana/docker-compose.yml | 2 ++ docker-compose/examples/hashicorpvault/docker-compose.yml | 1 + .../{{ cookiecutter.__project_slug }}/docker-compose.yml | 2 ++ 3 files changed, 5 insertions(+) diff --git a/docker-compose/examples/grafana/docker-compose.yml b/docker-compose/examples/grafana/docker-compose.yml index 0d44484..3bb4569 100644 --- a/docker-compose/examples/grafana/docker-compose.yml +++ b/docker-compose/examples/grafana/docker-compose.yml @@ -1,5 +1,6 @@ services: grafana: + # FIXME Docker Hub image name with or without slash? FIXME image: "grafana:${GRAFANA_VERSION}" container_name: "grafana-grafana-${CONTEXT}" networks: @@ -28,6 +29,7 @@ services: # GRAFANA_USER: ${GRAFANA_USER} # GRAFANA_PASSWORD: ${GRAFANA_PASSWORD} nginx: + # FIXME Docker Hub image name with or without slash? FIXME image: "nginx:${NGINX_VERSION}" container_name: "grafana-nginx-${CONTEXT}" networks: diff --git a/docker-compose/examples/hashicorpvault/docker-compose.yml b/docker-compose/examples/hashicorpvault/docker-compose.yml index 0609eb1..5314a01 100644 --- a/docker-compose/examples/hashicorpvault/docker-compose.yml +++ b/docker-compose/examples/hashicorpvault/docker-compose.yml @@ -1,5 +1,6 @@ services: vault: + # FIXME Docker Hub image name with or without slash? FIXME image: "vault:${VAULT_VERSION}" container_name: "vault-${CONTEXT}" networks: diff --git a/docker-compose/{{ cookiecutter.__project_slug }}/docker-compose.yml b/docker-compose/{{ cookiecutter.__project_slug }}/docker-compose.yml index dc62bb4..62df158 100644 --- a/docker-compose/{{ cookiecutter.__project_slug }}/docker-compose.yml +++ b/docker-compose/{{ cookiecutter.__project_slug }}/docker-compose.yml @@ -12,6 +12,7 @@ services: {%- endfor -%} {%- for component in components %} {{ component }}: + # FIXME Docker Hub image name with or without slash? FIXME image: "{{ component }}:${% raw %}{{% endraw %}{{ component.upper() }}_VERSION{% raw %}}{% endraw %}" container_name: "{{ cookiecutter.__service_slug }}-{{ component }}-${CONTEXT}" networks: @@ -51,6 +52,7 @@ services: {%- endfor -%} {%- else %} {{ cookiecutter.__component_list_slug }}: + # FIXME Docker Hub image name with or without slash? FIXME image: "{{ cookiecutter.__component_list_slug }}:${% raw %}{{% endraw %}{{ cookiecutter.__component_list_slug.upper() }}_VERSION{% raw %}}{% endraw %}" container_name: "{{ cookiecutter.__service_slug }}-${CONTEXT}" networks: