Trigger file desciptor restart condition only in /bin/ dirs #3

New Issue

2024-06-19T17:57:40Z

hygienic-books commented

2024-06-19 17:57:40 +00:00

Resolution to issue #1 was a bit too aggressive on closer inpsection. With it we introduced behavior where any open file descriptor listed by an lsof command would trigger a system reboot. This would frequently include file descriptors for memory-backed anonymous files in /memfd and shared memory objects in /dev/shm which weren't our concern in #1. We care about binaries such as dockerd and zabbix_agent2 still running in old versions via open file descriptors.

Let's reduce the list of lsof results: As a good enough approximation we can begin caring only about file descriptors that point to a path that includes string /s?bin/ where s? is supposed to mean an optional character s. This will cover /usr/sbin/, /usr/local/bin/ etc. and should get us most of the way there for what the intent behind #1 was.

Resolution to issue #1 was a bit too aggressive on closer inpsection. With it we introduced behavior where any open file descriptor listed by an `lsof` command would trigger a system reboot. This would frequently include file descriptors for memory-backed anonymous files in `/memfd` and shared memory objects in `/dev/shm` which weren't our concern in #1. We care about binaries such as `dockerd` and `zabbix_agent2` still running in old versions via open file descriptors. Let's reduce the list of `lsof` results: As a good enough approximation we can begin caring only about file descriptors that point to a path that includes string `/s?bin/` where `s?` is supposed to mean an optional character `s`. This will cover `/usr/sbin/`, `/usr/local/bin/` etc. and should get us most of the way there for what the intent behind #1 was.

hygienic-books referenced this issue from a commit

2024-06-19 18:16:54 +00:00

fix(script): Trigger restart only on FDs for binaries (#3)

hygienic-books referenced this issue

2024-06-19 18:17:30 +00:00

fix(script): Trigger restart only on FDs for binaries (#3) #4

hygienic-books referenced this issue from a commit

2024-06-19 18:17:56 +00:00

Merge pull request 'fix(script): Trigger restart only on FDs for binaries (#3)' (#4) from 3/fix-3-only-reboot-when-binaries-change into main

hygienic-books closed this issue

2024-06-19 18:17:56 +00:00

Sign in to join this conversation.