fix(os): chown instead of chmod works wonders (#1)

README.md

@@ -22,6 +22,17 @@ The scripts takes the following installation steps.
 
 1. Install ZFS with [github.com/eoli3n/archiso-zfs](https://github.com/eoli3n/archiso-zfs)
 
+# Post-run manual steps
+
+When all is said and done you're goig to want to at least touch these points in your new Arch Linux install:
+
+* Hostname: We chose a pseudo-randomly generated 8-character string with `pwgen`
+* Unprivileged user accounts: The OS was installed only with a `root` account
+* Passwords
+
+    * ZFS: The password for all datasets underneath `zpool` is `password`.
+    * Local `root` account: The local `root` account's password is `password`.
+
 # Assumptions
 
 # Development

setup.sh

@@ -18,6 +18,9 @@ function we_are_changerooted () {
 }
 
 function update_pacman_db () {
+    systemctl start reflector
+    # In an ISO and for the minimal number of packages we need we do not
+    # care about partial upgrades
     pacman -Sy
 }
 
@@ -27,7 +30,9 @@ function install_pkgs () {
 }
 
 function install_zfs () {
+    declare reset_colors='\033[0m'
     curl -s 'https://raw.githubusercontent.com/eoli3n/archiso-zfs/master/init' | bash
+    printf -- "${reset_colors}"
 }
 
 function get_partitions () {
@@ -83,7 +88,7 @@ function we_have_exactly_one_part () {
 function no_zpool_exists () {
     declare zpool_list
     zpool_list="$(zpool list -H)"
-    [[ "$(wc -l <<<"${zpool_list}")" -eq '0' ]] && return 0
+    [[ "$(wc -l <<<"${zpool_list}")" -le '1' ]] && [[ "$(wc -c <<<"${zpool_list}")" -le '1' ]] && return 0
     return 1
 }
 
@@ -163,6 +168,9 @@ function setup_zpool () {
         create_home_dataset
         export_pool
         import_pool
+    else
+        printf -- '%s\n' 'A zpool already exists, that is unexpected. Cowardly exiting 1 ...'
+        exit 1
     fi
 }
 
@@ -315,7 +323,7 @@ function get_aur_helper () {
     printf -- '%s\n' '%wheel ALL=(ALL:ALL) NOPASSWD: ALL' > '/etc/sudoers.d/10-wheel-group-no-passwd-prompt'
     pushd /tmp
     git clone 'https://aur.archlinux.org/paru.git'
-    chmod -R 'build:' 'paru'
+    chown -R 'build:' 'paru'
     pushd 'paru'
     sudo --user 'build' makepkg -si --noconfirm
     popd
@@ -485,7 +493,6 @@ function main () {
             setup_zpool "${zfs_part}"
             mount_system
             copy_zpool_cache
-            systemctl start reflector
             install_archlinux
             gen_fstab
             set_hostname