diff --git a/README.md b/README.md index 07420b4..7aa48c3 100644 --- a/README.md +++ b/README.md @@ -101,6 +101,8 @@ zpool/root/archlinux@pacman_2023-03-07-0114_op:inst_sev:trv zpool/root/archlinux@pacman_2023-03-07-0115_op:upgr_sev:trv ``` +Whatever you set as your `pkgs_list_max_length` is still just a best effort as it is subject to ZFS' internal maximum for dataset name length. This limit is currently 255 characters. For a snapshot this is counted against the dataset name in front of the `@` character plus everything else starting with the `@` character til the end. If you'd like e.g. 200 characters allocated to the package list chances are that you'll see fewer characters than that depending on how long your dataset names are on their own. + Have a look at `pacman-zfs-snapshot.conf` as well, its comments should be clear enough to get you going. # Rollback diff --git a/pacman-zfs-snapshot.sh b/pacman-zfs-snapshot.sh index f716792..40b4023 100755 --- a/pacman-zfs-snapshot.sh +++ b/pacman-zfs-snapshot.sh @@ -202,8 +202,9 @@ function trim_pkg_list_oneline () { local available_pkg_list_length available_pkg_list_length="$((${max_zfs_snapshot_name_length} - ${max_dataset_name_length}))" if [[ "${available_pkg_list_length}" -lt "${pkgs_list_max_length}" ]]; then - # If we have fewer characters available than the user wants limit - # package list length + # If we have fewer characters available before hitting the + # ZFS internal maximum snapshot name length than the user + # wants limit package list length. pkgs_list_max_length="${available_pkg_list_length}" fi