From 7a494cb65af96b18139a289a9ad66f3c926c8e18 Mon Sep 17 00:00:00 2001
From: hygienic-books <hygienic-books@tentic.net>
Date: Tue, 7 Mar 2023 01:02:43 +0100
Subject: [PATCH] fix(script): Correctly assign default values if unset or
 empty (#1)

---
 pacman-zfs-snapshot.sh | 28 ++++++++++++++--------------
 1 file changed, 14 insertions(+), 14 deletions(-)

diff --git a/pacman-zfs-snapshot.sh b/pacman-zfs-snapshot.sh
index 3e05ea0..88f825d 100755
--- a/pacman-zfs-snapshot.sh
+++ b/pacman-zfs-snapshot.sh
@@ -14,20 +14,20 @@ if [[ -r "${conf_file}" ]]; then
 fi
 
 # User-defined
-if [[ ! "${do_dry_run}" ]]; then do_dry_run='true'; fi
-if [[ ! "${important_names}" ]]; then important_names='linux'; fi
-if [[ ! "${snaps_trivial_keep}" ]]; then snaps_trivial_keep='15'; fi
-if [[ ! "${snaps_important_keep}" ]]; then snaps_important_keep='5'; fi
-if [[ ! "${snaps_trivial_suffix}" ]]; then snaps_trivial_suffix='trv'; fi
-if [[ ! "${snaps_important_suffix}" ]]; then snaps_important_suffix='imp'; fi
-if [[ ! "${pkgs_list_max_length}" ]]; then pkgs_list_max_length='30'; fi
-if [[ ! "${snap_only_local_datasets}" ]]; then snap_only_local_datasets='true'; fi
-if [[ ! "${snap_field_separator}" ]]; then snap_field_separator='_'; fi
-if [[ ! "${snap_name_prefix}" ]]; then snap_name_prefix='pac'; fi
-if [[ ! "${snap_date_format}" ]]; then snap_date_format='%F-%H%M'; fi
-if [[ ! "${snap_op_installation_suffix}" ]]; then snap_op_installation_suffix='inst'; fi
-if [[ ! "${snap_op_remove_suffix}" ]]; then snap_op_remove_suffix='rmvl'; fi
-if [[ ! "${snap_op_upgrade_suffix}" ]]; then snap_op_upgrade_suffix='upgr'; fi
+do_dry_run="${do_dry_run:-true}"
+important_names="${important_names:-linux}"
+snaps_trivial_keep="${snaps_trivial_keep:-15}"
+snaps_important_keep="${snaps_important_keep:-5}"
+snaps_trivial_suffix="${snaps_trivial_suffix:-trv}"
+snaps_important_suffix="${snaps_important_suffix:-imp}"
+pkgs_list_max_length="${pkgs_list_max_length:-30}"
+snap_only_local_datasets="${snap_only_local_datasets:-true}"
+snap_field_separator="${snap_field_separator:-_}"
+snap_name_prefix="${snap_name_prefix:-pac}"
+snap_date_format="${snap_date_format:-%F-%H%M}";
+snap_op_installation_suffix="${snap_op_installation_suffix:-inst}"
+snap_op_remove_suffix="${snap_op_remove_suffix:-rmvl}"
+snap_op_upgrade_suffix="${snap_op_upgrade_suffix:-upgr}"
 
 # Internal
 declare pkg_separator max_zfs_snapshot_name_length color_reset color_lyellow color_red