From c9fcdb5b2961aba44a1a381c0ee470bc2d2045f2 Mon Sep 17 00:00:00 2001
From: hygienic-books <hygienic-books@tentic.net>
Date: Tue, 7 Mar 2023 00:03:01 +0100
Subject: [PATCH] refactor(script): Differentiate between user-defined and
 internal vars (#1)

---
 pacman-zfs-snapshot.sh | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/pacman-zfs-snapshot.sh b/pacman-zfs-snapshot.sh
index 3882f4d..347595e 100755
--- a/pacman-zfs-snapshot.sh
+++ b/pacman-zfs-snapshot.sh
@@ -16,6 +16,7 @@ if [[ -r "${conf_file}" ]]; then
     source "${conf_file}"
 fi
 
+# User-defined
 if [[ ! "${do_dry_run}" ]]; then do_dry_run='true'; fi
 if [[ ! "${important_names}" ]]; then important_names='linux'; fi
 if [[ ! "${snaps_trivial_keep}" ]]; then snaps_trivial_keep='15'; fi
@@ -31,6 +32,11 @@ if [[ ! "${snap_op_installation_suffix}" ]]; then snap_op_installation_suffix='i
 if [[ ! "${snap_op_remove_suffix}" ]]; then snap_op_remove_suffix='rmvl'; fi
 if [[ ! "${snap_op_upgrade_suffix}" ]]; then snap_op_upgrade_suffix='upgr'; fi
 
+# Internal
+declare pkg_separator max_zfs_snapshot_name_length
+pkg_separator=':'
+max_zfs_snapshot_name_length='255'
+
 function pprint () {
     local style msg exit_code
     style="${1:?}"
@@ -260,9 +266,8 @@ function main () {
     local unabridged_pkg_list_oneline
     write_pkg_list_oneline
 
-    local date_string max_zfs_snapshot_name_length max_dataset_name_length
+    local date_string max_dataset_name_length
     date_string="$(date +"${snap_date_format}")"
-    max_zfs_snapshot_name_length='255'
     find_max_dataset_name_length
 
     local trimmed_pkg_list_oneline